-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Acosd function #9876
Conversation
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9425213 | Triggered | Generic Password | a271c3c | ci/scripts/e2e-source-test.sh | View secret |
9425213 | Triggered | Generic Password | a271c3c | ci/scripts/e2e-sink-test.sh | View secret |
9425213 | Triggered | Generic Password | a271c3c | ci/scripts/e2e-source-test.sh | View secret |
9425213 | Triggered | Generic Password | a271c3c | ci/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@xiangjinwu Sorry, I completely forgot about this one. Does this LGTY? |
No worries. We received no requests from customers needing trigonometric functions 😂 |
Guess so 😂 Was still nice to work on the kernel side for a while. |
No idea why we get these imprecisions. Doing everything just like the PG implementation. Maybe it is a difference between Rust and C? For now I will hardcode these cases. I feel like it is not wort putting more energy into this.
|
Shall we merge it @xiangjinwu ? 😁 If we really don't need the function at the moment I'd suggest to close the PR. |
I am looking at several avro issues recently 🥵 |
No worries. I think this is low priority 😁 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the
Acosd
function. This implementation is slightly different from the PSQL implementation. I do not return an error onacosd(Inf)
, but instead returnNaN
. Also returnsNaN
when inout is out of range.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
acosd
trigonometric function implementation.Release note
Add
acosd
function, which calculates the inverse acos in degrees.